T8031: file comparison in boolean check unsaved_commits should ignore blank lines #4864
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
12 tasks
c-po
approved these changes
Nov 22, 2025
Member
c-po
left a comment
c-po
left a comment
There was a problem hiding this comment.
strip() whitespaces before comparing the running configuration with the saved configuration.
|
CI integration 👍 passed! Details
|
jestabro
force-pushed
the
util-file-compare
branch
from
c3a6ba9 to
0bc7898
Compare
Contributor
Author
|
Force pushed trivial formatting change to make ruff happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Discrepancies in blank lines, whitespace, or missing final newline can lead to false positives in the boolean check unsaved_commits, which is used to provide warning messages on reboot/poweroff and commit-confirm.
The discrepancies can arise due to automated formatting at boot from migration/activation scripts or intialization on first install; such discrepancies trigger a false positive due to the use of Python's filecmp module.
Irrespective of consistent formatting, use a smarter file comparison utility.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: